Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elements: 0.18.1.12 -> 0.21.0 #142894

Merged
merged 1 commit into from
Oct 26, 2021
Merged

elements: 0.18.1.12 -> 0.21.0 #142894

merged 1 commit into from
Oct 26, 2021

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Oct 25, 2021 •
edited
Loading

Motivation for this change
  • new version update
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member Author

prusnak commented Oct 25, 2021

@GrahamcOfBorg build elementsd elements

jonasnick
jonasnick reviewed Oct 26, 2021
View reviewed changes
Copy link
Contributor

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I verified the signature with this script and I can run the binaries (including GUI).

@prusnak prusnak merged commit b870c24 into NixOS:master Oct 26, 2021
@prusnak prusnak deleted the elements branch October 26, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasnick jonasnick jonasnick left review comments

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prusnak @jonasnick