python3Packages.simple_di: init at 0.1.2 #142910
Conversation
| ]; | ||
|
|
||
| meta = { | ||
| description = "simple dependency injection library"; |
There was a problem hiding this comment.
Start descriptions with an uppercase.
| description = "simple dependency injection library"; | |
| description = "Simple dependency injection library"; |
There was a problem hiding this comment.
Somehow I misread "should be capitalized" as "should not be capitalized."
|
OfBorg is hung up. |
| @@ -8450,6 +8450,8 @@ in { | |||
|
|
|||
| simplekml = callPackage ../development/python-modules/simplekml { }; | |||
|
|
|||
| simple_di = callPackage ../development/python-modules/simple_di { }; | |||
There was a problem hiding this comment.
The name is not normalised. It must be simple-di.
| ] ++ lib.optional (pythonOlder "3.7") [ | ||
| dataclasses | ||
| ]; | ||
|
|
There was a problem hiding this comment.
Missing pythonImportCheck and checkPhase.
| buildPythonPackage rec { | ||
| version = "0.1.2"; | ||
| pname = "simple_di"; | ||
| disabled = pythonOlder "3.6.1"; |
There was a problem hiding this comment.
This should be version "3.6".
| version = "0.1.2"; | ||
| pname = "simple_di"; |
There was a problem hiding this comment.
| version = "0.1.2"; | |
| pname = "simple_di"; | |
| pname = "simple-di"; | |
| version = "0.1.2"; |
|
@AndersonTorres please don't merge python PRs which are not fully up to standard. This PR was definitely not LGTM. |
|
Should I be making a new PR for this? |
Yes.
Apologies for the incident. |
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)