xe-guest-utilities: init at 6.2.0 #14305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done:
nix-build --option build-use-chroot true
or nix.useChroot on NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)More
cc @benwbooth
Notes:
I'm using NixOS at work, where we use Citrix Xen as our VM Host. The xe-guest-utilities allows me to query the Xen host for IP addresses of VMs, a crucial feature for me, which is why I went through the trouble of packaging this.
I based this off of the xe-guest-utilities ArchLinux package. Citrix seems to require a login to download the files, so ArchLinux keeps a copy on their servers. This expression downloads the source from the Arch Linux servers, I'm not sure if that's a problem or if there's a better place to put the source files.
I did not add the services to the
nixos/modules/virtualisation/xen-domU.nix
and did not add the module to themodule-list.nix
. Since this is a new module I think it should be completely opt-in, at least until it gets more testing.I've tested it so far on my NixOS VM, and I am able to query for IP addresses now.
I had trouble running the
nox-review wip
command. I'm not sure if this is because I already made the commit before I ran the command. It says this:and then proceeds to list all the files in my local nixpkgs tree. This is my first package submission so I'm still learning the Nix way of doing things.
Please let me know if there's any corrections to be made or problems. Thanks!