Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xe-guest-utilities: init at 6.2.0 #14305

Merged
merged 1 commit into from
Mar 31, 2016

Conversation

benwbooth
Copy link
Contributor

Things done:
  • Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
More

cc @benwbooth

Notes:

I'm using NixOS at work, where we use Citrix Xen as our VM Host. The xe-guest-utilities allows me to query the Xen host for IP addresses of VMs, a crucial feature for me, which is why I went through the trouble of packaging this.

I based this off of the xe-guest-utilities ArchLinux package. Citrix seems to require a login to download the files, so ArchLinux keeps a copy on their servers. This expression downloads the source from the Arch Linux servers, I'm not sure if that's a problem or if there's a better place to put the source files.

I did not add the services to the nixos/modules/virtualisation/xen-domU.nix and did not add the module to the module-list.nix. Since this is a new module I think it should be completely opt-in, at least until it gets more testing.

I've tested it so far on my NixOS VM, and I am able to query for IP addresses now.

I had trouble running the nox-review wip command. I'm not sure if this is because I already made the commit before I ran the command. It says this:

==> We're in a git repo, trying to fetch it
error: The following untracked working tree files would be overwritten by checkout:

and then proceeds to list all the files in my local nixpkgs tree. This is my first package submission so I'm still learning the Nix way of doing things.

Please let me know if there's any corrections to be made or problems. Thanks!

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @zimbatm, @edolstra and @vcunat to be potential reviewers

cfg = config.services.xe-guest-utilities;
in {
options = {
services.xe-guest-utilities = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use mkEnableOption.

@fpletz
Copy link
Member

fpletz commented Mar 30, 2016

I did not add the services to the nixos/modules/virtualisation/xen-domU.nix and did not add the module to the module-list.nix

I think it's ok to add this module to module-list.nix because otherwise this service module can't be used easily. It isn't enabled by default so this shouldn't really matter.

Thanks! The code looks ok to me. If you add this module to module-list.nix and squash your commits, I think we can merge this and maybe later enable this by default for Xen domUs. 👍

use mkEnableOption

use sha256

add xe-guest-utilities to module-list.nix
@benwbooth
Copy link
Contributor Author

Thanks for all the feedback! Please let me know if there's anything else I need to fix.

@fpletz fpletz merged commit e5334ce into NixOS:master Mar 31, 2016
@benwbooth benwbooth deleted the xe-guest-utilities-6.2.0 branch March 31, 2016 16:16
@benwbooth benwbooth restored the xe-guest-utilities-6.2.0 branch April 14, 2016 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants