Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebar3-nix-bootstrap: correct homepage URL #14384

Merged
merged 1 commit into from
Apr 2, 2016

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Apr 2, 2016

Things done:
  • Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
More

cc @ericbmerritt


Please note, that points are not mandatory, but rather desired.

Correct homepage URL: s/erl-nix/erlang-nix/

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @ericbmerritt and @gleber to be potential reviewers

@yurrriq yurrriq changed the title Update rebar3-nix-bootstrap rebar3-nix-bootstrap: correct homepage URL Apr 2, 2016
@gleber
Copy link
Contributor

gleber commented Apr 2, 2016

Looks good to me! Thanks for a fix. I can not merge it myself, though.

@gebner
Copy link
Member

gebner commented Apr 2, 2016

Please change the commit message to "rebar3-nix-bootstrap: ..." as requested in the nixpkgs manual.

@yurrriq
Copy link
Member Author

yurrriq commented Apr 2, 2016

I can likely do it tomorrow. The manual was unclear to me and I think...

format the commit in a following way

... should instead read...

format the commit message as follows

I'll make similar changes to my other PRs, too. Thanks for the feedback.

@yurrriq yurrriq force-pushed the patch-rebar3-nix-bootstrap branch from dc85057 to b11d859 Compare April 2, 2016 20:45
@joachifm joachifm merged commit 58bb768 into NixOS:master Apr 2, 2016
@yurrriq yurrriq deleted the patch-rebar3-nix-bootstrap branch July 6, 2016 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants