Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnaural: build with gcc49 #14407

Merged
merged 1 commit into from
Apr 4, 2016
Merged

gnaural: build with gcc49 #14407

merged 1 commit into from
Apr 4, 2016

Conversation

ktosiek
Copy link
Contributor

@ktosiek ktosiek commented Apr 2, 2016

Things done:
  • Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
More

Fixes building gnaural

cc @ehmry

@joachifm joachifm added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 2, 2016
@ktosiek
Copy link
Contributor Author

ktosiek commented Apr 2, 2016

@joachifm how do I do that? Open a second PR against release-16.03?

@joachifm
Copy link
Contributor

joachifm commented Apr 3, 2016

You could do that, but in this case I'll just cherry-pick it. I added the label only as a reminder.

@joachifm joachifm merged commit 6448f25 into NixOS:master Apr 4, 2016
@joachifm
Copy link
Contributor

joachifm commented Apr 4, 2016

Picked to release at 4a75df9

@ktosiek ktosiek deleted the gnaural-gcc branch April 4, 2016 10:35
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants