emacsPackages: remove outdated helm #14420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase on top of master ? It looks like there is a merge conflict |
|
cc @oxij |
|
@zimbatm not sure how the conflict happened (I rebased and didn't see anything), but updated anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done:
nix-build --option build-use-chroot true -A emacsPackagesNg.helm)emacsWithPackages (epkgs: [ epkgs.helm epkgs.helm-projectile ])./result/bin/)More
helm-20150105was added in #6250, which looks like an abandoned path since we now have automatically generated melpa packages.Meanwhile,
helm-projectile(probably among other packages) requires a newerhelm(one that hashelm-types.eli.e. 1.7.7 onwards).helm-1.9.2is already inmelpa-stable-generated.nix. This removal makes that work (and hopefully others).Question: is there any plan for
emacs-packages.nix? IIUC it's just there for overrides (e.g. when some auto generated melpa packages are broken). If there are melpa generated packages that aren't broken, they should be removed fromemacs-packages.nix, is that correct?Please note, that points are not mandatory, but rather desired.