Avoid conflicts in emacs withpackages #14429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid unwanted side effects when installing a wrapped emacs in the environment: * All executables in the dependencies become available in the user environment * All site-lisp binaries in the dependencies become accessible to unwrapped emacs Also, both bin and site-lisp would generate conflicts so installing a wrapped emacs becomes really cumbersome
|
By analyzing the blame information on this pull request, we identified @ttuegel to be a potential reviewer |
I agree this would be ideal, but I think this suffices for now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12738 introduced a change that exposes all dependencies of a wrapped emacs in the general bin directory (same for the elisp dependencies in the general site-lisp directory).
I use emacsWithPackages to install an emacs in my env with all the packages I use, after that change I both get conflicts with installed packages and undesired binaries in my PATH.
This change moves the binaries and elisp files to a "private" directory to avoid exposing them too much.
Still, I preferred the previous implementation that just added the paths in the store to site-start, but I gather that is too slow for some users. Maybe a better solution would be to create a path in the store with links to all the dependencies and add that single path to site-start.
Things done:
nix-build --option build-use-chroot trueor nix.useChroot on NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)More
Fixes issue #
cc @ttuegel
Please note, that points are not mandatory, but rather desired.