Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcre2: ftp.pcre.org looks defunct #145546

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Conversation

baloo
Copy link
Member

@baloo baloo commented Nov 11, 2021

Motivation for this change

According to pcre.org github is now the official mirror for releases.

cc @ttuegel

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Mindavi
Copy link
Contributor

Mindavi commented Nov 11, 2021

Hash is still ok?

@samueldr
Copy link
Member

Hash is still ok?

It's possible. It's not generated code, but uploaded assets:

Though a simple TOFU check by breaking the hash can help verify.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperSandro2000
Copy link
Member

Hash is still ok?

It's possible. It's not generated code, but uploaded assets:

* [PhilipHazel/pcre2@`pcre2-10.37` (release)](https://github.com/PhilipHazel/pcre2/releases/tag/pcre2-10.37)

Though a simple TOFU check by breaking the hash can help verify.

Verified locally and it is the same hash.

Waiting for ofborg and then merging.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Nov 11, 2021
@baloo
Copy link
Member Author

baloo commented Nov 11, 2021

Hash is still ok?

$ nix-build . -A pcre2.src --check
checking outputs of '/nix/store/12lw9q06n2j6h5x8hsamdsh3yjk2i6g9-pcre2-10.37.tar.bz2.drv'...

trying https://github.com/PhilipHazel/pcre2/releases/download/pcre2-10.37/pcre2-10.37.tar.bz2
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   658  100   658    0     0   2043      0 --:--:-- --:--:-- --:--:--  2043
100 1688k  100 1688k    0     0   779k      0  0:00:02  0:00:02 --:--:-- 1745k
/nix/store/an15rwsimzw7ncwkxxn22ahkjh73npjk-pcre2-10.37.tar.bz2

as far as I can tell, yes.

@SuperSandro2000 SuperSandro2000 merged commit 2644b4d into NixOS:master Nov 11, 2021
@baloo baloo deleted the baloo/pcre2/src branch November 11, 2021 21:21
@baloo baloo mentioned this pull request Nov 12, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: reproducible builds 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants