avro-c++: Init at 1.7.5 #14811
Merged
avro-c++: Init at 1.7.5 #14811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,26 @@ | |||
| { stdenv, fetchurl, cmake, boost155, python | |||
There was a problem hiding this comment.
If you're only interested in the python interpreter, I believe the preferred method of getting at it is passing in pythonPackages and using pythonPackages.python in the build inputs.
|
Apart from a few minor issues, this looks superficially okay |
|
@joachifm, I've addressed all questions. |
| { stdenv, fetchurl, cmake, boost155, pythonPackages | ||
| }: | ||
|
|
||
| let version = "1.7.5"; in |
There was a problem hiding this comment.
No need to update this, but the idiom is
stdenv.mkDerivation rec {
name = "foo-${version}";
version = "4.2";
}Note the rec keyword allows you to refer to keys within the same attrset.
There was a problem hiding this comment.
Yay, I know. I just looked through sample packages in nixpkgs manual and found next style is more common:
let version = "4.2"; in
stdenv.mkDerivation {
name = "foo-${version}";
}There was a problem hiding this comment.
rec is used way more, but it doesn't matter.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix-build --option build-use-chroot trueor nix.useChroot on NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)