Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

writers.makePythonWriter: disable flake8 checks for Python 2 #148403

Merged
merged 2 commits into from
Dec 5, 2021

Conversation

elohmeier
Copy link
Contributor

Motivation for this change

Flake8 dropped support for Python 2 starting with version 4. Script writers like writePython2/writePython2Bin checks fail due to that incompatibility.

Things done

Disabled flake8 for Python 2, disabled flake8 check for generated Python 2 scripts.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so python2 seems really to be gone for good :)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2021

Successfully created backport PR #148687 for release-21.11.

@elohmeier elohmeier deleted the py2-flake8 branch December 5, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants