Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kodi: fix cross build #148924

Merged
merged 1 commit into from
Dec 6, 2021
Merged

kodi: fix cross build #148924

merged 1 commit into from
Dec 6, 2021

Conversation

dwagenk
Copy link
Contributor

@dwagenk dwagenk commented Dec 6, 2021

Motivation for this change

kodi doesn't cross-compile.

> checking whether we are cross compiling... configure: error: in `/build/source/tools/depends/native/JsonSchemaBuilder/native':
> configure: error: cannot run C++ compiled programs.
> If you meant to cross compile, use `--host'.
> See `config.log' for more details
> make: *** [Makefile:30: native] Error 77
> make: Leaving directory '/build/source/tools/depends/native/JsonSchemaBuilder'
error: attribute 'runtimeShell' missing
Things done

Built kodi with optional features disabled. Also the dependency lirc would bring in libftdi and the default jre_headless would bring in gtk3, both having cross-compile issues as well.

nix build -I nixpkgs=./ --impure --expr '(
import <nixpkgs> {
  overlays = [ (self: super: { 
    lirc = null; 
    kodi = super.kodi.override {
      waylandSupport = true;
      x11Support = false;
      gbmSupport = false;
      dbusSupport = false;
      joystickSupport = false;
      nfsSupport = false;
      pulseSupport = false;
      sambaSupport = false;
      udevSupport = false;
      usbSupport = false;
      vdpauSupport = false;
      jre_headless = self.buildPackages.adoptopenjdk-jre-openj9-bin-11;
    };
  }) ]; 
} ).pkgsCross.aarch64-multiplatform.kodi'
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
    Tested by building an aarch64 sdImage containing kodi-wayland. It runs fine, though I only tested basic functionality (menus, local media)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

credits to @telent (https://github.com/telent/nixelec/blob/main/configuration.nix#L100)

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Dec 6, 2021
@Mic92 Mic92 merged commit fcf7657 into NixOS:master Dec 6, 2021
@dwagenk dwagenk deleted the cross-fixes-kodi branch December 6, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants