gupnp-tools and releated packages: fix and update #1496
Conversation
| @@ -1,11 +1,12 @@ | |||
| { stdenv, fetchurl, pkgconfig, glib, libxml2, gssdp, libsoup, libuuid }: | |||
|
|
|||
| stdenv.mkDerivation { | |||
| name = "gupnp-0.18.4"; | |||
| name = "gupnp"; | |||
There was a problem hiding this comment.
add also version in the name
|
Thanks, I fixed the issues you mentioned. |
| { stdenv, fetchurl, gupnp, pkgconfig }: | ||
|
|
||
| stdenv.mkDerivation { | ||
| name = "gupnp-av-0.12.4"; |
There was a problem hiding this comment.
sorry to bug you so much but i guess receiving comments on pull requests will let you learn how to package using nix better.
you can actually reuse parameters inside attribute set so this expression would look like:
stdenv.mkDerivation rec {
name = "gupnp-av-${version}";
version = "0.12.4";
src = fetchurl {
url = mirror://gnome/sources/gupnp-av/0.12/${name}.tar.xz;
...
(notice the rec there)
then this is easier to upgrade next time since you only change version in one place.
There was a problem hiding this comment.
Is it also possible to generate the 0.12 part in the url?
There was a problem hiding this comment.
Quoting Benno Fünfstück (2014-01-13 13:34:51)
In pkgs/development/libraries/gupnp-av/default.nix:
@@ -0,0 +1,20 @@
+{ stdenv, fetchurl, gupnp, pkgconfig }:
+
+stdenv.mkDerivation {
- name = "gupnp-av-0.12.4";
Is it also possible to generate the 0.12 part in the url?
you could do
majorVersion = "0.12";
version = "${majorVersion}.4};
src = {
url = "....${majorVersion}/gupnp-av-${version}";
...
at least thats how other did it in their distributions.
Rok Garbas - http://www.garbas.si
|
Ok, is there anything more I can do? |
|
i get https://gist.github.com/garbas/8492171 error when trying to build libsoup (one of the dependencies of gupnp-tools). does it build for you? |
|
I just tested it here again, works fine for me. Maybe I should try building with chroot builds enabled? I have python installed, so that might be the reason it works. |
|
Do you have chroot enabled in /etc/nix/nix.conf? If not, enable it and
|
|
Ah, the issue was that |
|
Looks good. It would be good to remove libsoup 2.44 that we are using in gnome3 and just use the updated one |
|
I've removed all references to libsoup_2_44 and rebased. |
gupnp-tools and releated packages: fix and update
|
Thank you! |
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/singularity/versions. <details><summary>Version release notes (from GitHub)</summary> Greetings Singularity containerizers! This release contains fixes for a _high severity_ security issue affecting Singularity 2.3.0 through 2.5.1 on kernels that support overlay file systems (CVE-2018-12021). A malicious user with network access to the host system (e.g. ssh) could exploit this vulnerability to access sensitive information on disk and bypass directory image restrictions like those preventing the root file system from being mounted into the container. Singularity 2.5.2 should be installed immediately, and all previous versions of Singularity should be removed. The vulnerability addressed in this release affects kernels that support overlayfs. If you are unable to upgrade immediately, you should set `enable overlay = no` in `singularity.conf`. In addition, this release contains a large number of bug fixes. Details follow: ## [Security related fixes](https://cve.mitre.org/cgi-bin/cvename.cgi?name=2018-12021) - Removed the option to use overlay images with `singularity mount`. This flaw could allow a malicious user accessing the host system to access sensitive information when coupled with persistent ext3 overlay. - Fixed a race condition that might allow a malicious user to bypass directory image restrictions, like mounting the host root filesystem as a container image ## Bug fixes - Fix an error in malloc allocation NixOS#1620 - Honor debug flag when pulling from docker hub NixOS#1556 - Fix a bug with passwd abort NixOS#1580 - Allow user to override singularity.conf "mount home = no" with --home option NixOS#1496 - Improve debugging output NixOS#1535 - Fix some bugs in bind mounting NixOS#1525 - Define PR_(S|G)ET_NO_NEW_PRIVS in user space so that these features will work with kernels that implement them (like Cray systems) NixOS#1506 - Create /dev/fd and standard streams symlinks in /dev when using minimal dev mount or when specifying -c/-C/--contain option NixOS#1420 - Fixed * expansion during app runscript creation NixOS#1486 As always, please report any bugs to: https://github.com/singularityware/singularity/issues/new</details> These checks were done: - built on NixOS - /nix/store/3igwiqi311c18w13y5r7zrgpcnzylg9l-singularity-2.5.2/bin/singularity passed the binary check. - Warning: no invocation of /nix/store/3igwiqi311c18w13y5r7zrgpcnzylg9l-singularity-2.5.2/bin/run-singularity had a zero exit code or showed the expected version - 1 of 2 passed binary check by having a zero exit code. - 0 of 2 passed binary check by having the new version present in output. - found 2.5.2 with grep in /nix/store/3igwiqi311c18w13y5r7zrgpcnzylg9l-singularity-2.5.2 - directory tree listing: https://gist.github.com/ed6db09ad43a19c6abf2d35d15ef489c - du listing: https://gist.github.com/9bd23f4d6ee86a9eb2ba7ec5c986741d
I couldn't get the current gupnp-tools to build. This PR updates the related packages and
gupnp-tools and fixes the issues I were experiencing. I only tested this on linux, so further
testing is required for at least libsoup and gssdp (Maybe the other packages also work on other platforms?).