Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consoletools: copy utils to bin #15050

Merged
merged 1 commit into from
Apr 29, 2016
Merged

consoletools: copy utils to bin #15050

merged 1 commit into from
Apr 29, 2016

Conversation

ebzzry
Copy link

@ebzzry ebzzry commented Apr 28, 2016

No description provided.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @pSub, @aszlig and @wkennington to be potential reviewers

@jagajaga
Copy link
Member

cc @edolstra

makeFlags = [ "DESTDIR=$(out)"];

installPhase = ''
mkdir -p $out/bin
cp utils/ffcfstress $out/bin
Copy link
Contributor

@joachifm joachifm Apr 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equivalently, cp -t $out/bin utils/* EDIT: or even cp -R utils $out/bin, I guess ...

@ebzzry
Copy link
Author

ebzzry commented Apr 29, 2016

@joachifm fixed (∩_∩)

@joachifm
Copy link
Contributor

I wonder, does overriding the entire installPhase affect the output at all? Are you sure that whatever it used to install into the output is included still?

@ebzzry
Copy link
Author

ebzzry commented Apr 29, 2016

Currently on master, the installing profile does not have access to the binaries because they’re not copied to the correct directory.

@joachifm
Copy link
Contributor

@ebzzry what I mean is that now only the binaries are installed.

@joachifm
Copy link
Contributor

Actually, I just looked a bit closer and my suggestion is all wrong, as it would copy the source files into bin as well.

The actual problem is that make install puts things into $out/usr/local; overriding the entire installPhase is no good here.

@joachifm
Copy link
Contributor

make install uses $(DESTDIR)$(PREFIX), so what you want to do is set installFlags = ''PREFIX=""''.

@ebzzry
Copy link
Author

ebzzry commented Apr 29, 2016

@joachifm fixed =)

@joachifm
Copy link
Contributor

Thank you

@joachifm joachifm merged commit b539f8e into NixOS:master Apr 29, 2016
@ebzzry
Copy link
Author

ebzzry commented Apr 29, 2016

@joachifm Thanks! (/^▽^)/

@ebzzry ebzzry deleted the consoletools branch August 21, 2016 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants