ckan: Add curl to runtime libraries #15278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,7 +28,7 @@ stdenv.mkDerivation rec { | |||
| install -m 0644 $exe $out/bin | |||
| makeWrapper ${mono}/bin/mono $out/bin/$(basename $exe .exe) \ | |||
| --add-flags $out/bin/$exe \ | |||
| --set LD_LIBRARY_PATH ${gtk.out}/lib | |||
| --set LD_LIBRARY_PATH ${gtk.out}/lib:${curl.out}/lib | |||
There was a problem hiding this comment.
This may be more convenient as stdenv.lib.makeLibraryPath [ gtk curl ], or does that not work?
There was a problem hiding this comment.
I didn't know about it. Is there a list of these convenience functions somewhere?
There was a problem hiding this comment.
There probably should be, but I usually just root around in lib/
|
Thank you |
|
Hmm. Not really sure what could be causing that. |
|
Doesn't look related to this PR in particular, but mono is a complete unknown to me. It used to build, though (https://hydra.nixos.org/build/35332739) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)CKAN uses libcurl for some, but not all, downloads. We'd better include it.