Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sudo: 1.9.7p2 -> 1.9.8p2 #153281

Merged
merged 2 commits into from
Jan 4, 2022
Merged

sudo: 1.9.7p2 -> 1.9.8p2 #153281

merged 2 commits into from
Jan 4, 2022

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Jan 2, 2022

Motivation for this change

Long needed update of sudo. This took more time than expected due to three issues:

  • The original 1.9.8 release had a major bug breaking a common usage pattern of sudo (incl. the default deploy command for morph).
  • Something in the autoconf scripts changed and broke the build on !x86_64 systems, requiring the buildPackages change.
  • Lastly, the unit tests for sudo were flaky, and I didn't want to push a release without first confirming that the flakiness didn't come from the new release. As it turned out, this was a harmless bug in the tests, but better be safe than brick systems and require single-user mode recovery.
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@delroth
nixosTests.sudo: fix test flakiness
ac96423 
One of the subtests in the sudo NixOS test suite was broken: instead of
running the sudo invocation as user 'test2', it was running it as root.
Since root doesn't require a password to use sudo, this was causing
random "broken pipe" errors when trying to pass it a password via stdin.
@delroth
sudo: 1.9.7p2 -> 1.9.8p2
6886a9a
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jan 2, 2022
@delroth delroth mentioned this pull request Jan 2, 2022
Closed
@ofborg ofborg bot requested a review from edolstra January 3, 2022 00:02
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Jan 3, 2022
@SuperSandro2000 SuperSandro2000 merged commit 05fb73c into NixOS:master Jan 4, 2022
@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 4, 2022
Draft
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@dasj19 dasj19 dasj19 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delroth @SuperSandro2000 @dasj19