tensorflow: init at 0.8.0 #15329
tensorflow: init at 0.8.0 #15329
Conversation
| # tensorflow is built from a downloaded wheel, because the upstream | ||
| # project's build system is an arcane beast based on | ||
| # bazel. Untangling it and building the wheel from source is an open | ||
| # problem. |
There was a problem hiding this comment.
Support for installing wheels was added in #15010. It suffices to add the argument format="wheel".
There was a problem hiding this comment.
I switched it to use format = "wheel";. Do you want me to also take the comment out? I'd like to leave it in, because there is unfinished work here, and it would be better to eventually build from source - for example, because then we wouldn't need the preFixup stage below.
There was a problem hiding this comment.
no, I am glad you put the comment here.
|
While I think listing all the licenses is a good service to our users, what really matters is that none of the bundled sources are licensed in a way that makes it illegal to redistribute the whole. I'd find it incredibly deceptive if upstream provides a bundle that is in fact illegal to distribute, given that their advertised license certainly permits it. |
|
Thank you |
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)