gfold: init at 3.0.0

[shanesveller]

Motivation for this change

Introduces a new package, gfold, which is a CLI allowing bulk read-only review of the local git state of a tree of folders containing cloned/bare repositories.

Example usage:

gfold [--classic] path/to/some/tree

Example output:

# default
nixpkgs ~ /path/to/nixpkgs
  clean (shanesveller/gfold-3.0)
  git@github.com:shanesveller/nixpkgs.git
  <email>
# --classic
nixpkgs  clean  shanesveller/gfold-3.0  git@github.com:shanesveller/nixpkgs.git

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[shanesveller]

Result of nixpkgs-review pr 153893 run on x86_64-darwin 1

1 package built:

• gfold

[shanesveller]

Result of nixpkgs-review pr 153893 run on x86_64-linux 1

1 package built:

• gfold

[shanesveller]

The utility shells out to the Git CLI during execution - is makeWrapper the best preferred approach for this concern?

[AndersonTorres]

Suggested change

	description =
	"CLI tool to help keep track of your Git repositories, written in Rust";
	description = "A tool to help keep track of your Git repositories, written in Rust";

[shanesveller]

Hi @AndersonTorres, thanks for the review. I've changed this with your suggestion at 9a536f4d09f6de919790224a156e110f3312a29b.

Just to help me adapt as a new contributor, was this feedback more oriented around the phrasing or the newline? I have my editor using nixfmt by default and nixpkgs-fmt instead didn't seem to propose any diffs on the previous version.

[AndersonTorres]

The newline, primarily. It is weird to look a description not in the same line.

I suggested the new phrasing because I thought that the old one would break the 80-column limit. I would even suggest to remove the , written in Rust, but I think it would be excessive.

No worries, this is mostly stylistical.

[AndersonTorres]

The utility shells out to the Git CLI during execution - is makeWrapper the best preferred approach for this concern?

Yes. If it needs the git tool in $PATH, then it needs to be wrapped.

[AndersonTorres]

Squash those two latest commits into one.

[shanesveller]

I've squashed the two commits as requested, and I'm happy to address any further feedback as it arises.

[AndersonTorres]

LGTM, LGTBorg.

It takes some guts to start contributing to Nixpkgs with Rust packages!

[legendofmiracles]

Result of nixpkgs-review pr 153893 run on x86_64-linux 1

1 package built:

• gfold