Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mtr-exporter: init at 0.1.0 (3ce854a5) #153987

Merged
merged 1 commit into from
Jan 10, 2022
Merged

mtr-exporter: init at 0.1.0 (3ce854a5) #153987

merged 1 commit into from
Jan 10, 2022

Conversation

jakubgs
Copy link
Contributor

@jakubgs jakubgs commented Jan 8, 2022 •
edited
Loading

Motivation for this change

This is a useful utility for monitoring network performance over time using a combination of MTR and Prometheus.
Also adding a service definition.

I'm trying to avoid having to include the patch in the package, but we'll see: mgumz/mtr-exporter#2

My PR was merged and the author released a 0.1.0 version with the fixes.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 8, 2022
@jakubgs
Copy link
Contributor Author

jakubgs commented Jan 8, 2022

Here's an example of Grafana dashboard from monitoring a website using mtr-exporter and Prometheus:

image

Very useful for monitoring quality of an internet connection.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 8.has: package (new) This PR adds a new package labels Jan 8, 2022
@ofborg ofborg bot requested a review from kalbasit January 8, 2022 11:28
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild labels Jan 8, 2022
@jakubgs jakubgs force-pushed the init/mtr-exporter branch 2 times, most recently from e295eae to 084767a Compare January 8, 2022 11:44
pennae
pennae reviewed Jan 8, 2022
View reviewed changes
Copy link
Contributor

@pennae pennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new module also has to be added to nixos/modules/module-list.nix to be loaded by default, otherwise it'll have to be imported manually every time it is used.

nixos/modules/services/networking/mtr-exporter/mtr-exporter.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/mtr-exporter/mtr-exporter.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/mtr-exporter/mtr-exporter.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/mtr-exporter/mtr-exporter.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/mtr-exporter/mtr-exporter.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/mtr-exporter/default.nix Outdated Show resolved Hide resolved
@jakubgs jakubgs force-pushed the init/mtr-exporter branch 2 times, most recently from 911b530 to d70c6ba Compare January 8, 2022 13:02
@jakubgs jakubgs requested a review from pennae January 8, 2022 13:02
pennae
pennae reviewed Jan 8, 2022
View reviewed changes
Copy link
Contributor

@pennae pennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the derivation for mtr-exporter looks much better now too, hadn't even looked too closely at first! 👍

nixos/modules/services/networking/mtr-exporter.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/mtr-exporter.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/mtr-exporter.nix Show resolved Hide resolved
aanderse
aanderse reviewed Jan 8, 2022
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He there 👋 I left a few comments I hope you find helpful. I'm not familiar with this software so I can't leave an overly useful review... sorry.

Additionally, you'll want to follow the contributing guidelines and add release notes.

Thanks!

nixos/modules/services/networking/mtr-exporter.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/mtr-exporter.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/mtr-exporter.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/mtr-exporter.nix Show resolved Hide resolved
nixos/modules/services/networking/mtr-exporter.nix Show resolved Hide resolved
@jakubgs jakubgs force-pushed the init/mtr-exporter branch 3 times, most recently from ee60d42 to aa5d0aa Compare January 9, 2022 10:52
@jakubgs jakubgs changed the title mtr-exporter: init at 2020-03-08 (ab0b97a9) mtr-exporter: init at 0.1.0 (3ce854a5) Jan 9, 2022
@jakubgs
mtr-exporter: init at 0.1.0 (3ce854a5)
7d98886 
This is a useful utility for monitoring network performance over time
using a combination of MTR and Prometheus. Also adding a service definition.

Signed-off-by: Jakub Sokołowski <jakub@status.im>
aanderse
aanderse approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aanderse aanderse merged commit 03c291e into NixOS:master Jan 10, 2022
@jakubgs jakubgs deleted the init/mtr-exporter branch January 10, 2022 08:21
jakubgs added a commit to jakubgs/nixos-config that referenced this pull request Jan 17, 2022
@jakubgs
mtr-exporter: use version from nixos-unstable
74163a3 
Since my PR was merged for both the package and service:
NixOS/nixpkgs#153987

Signed-off-by: Jakub Sokołowski <jakub@status.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@pennae pennae pennae approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakubgs @aanderse @pennae