Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vala updates 2022-01-09 #154239

Merged
merged 5 commits into from
Jan 17, 2022
Merged

Vala updates 2022-01-09 #154239

merged 5 commits into from
Jan 17, 2022

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Jan 10, 2022 •
edited
Loading

Motivation for this change

Two releases in a day.
Drafting this until I am no longer tired... 😿 (#154086 (comment)) Just have some sleep...

Seems that I have read this yesterday...

Various improvements and bug fixes:

  • codegen:
    • Correctly handle chain up of struct creation methods [#1264]
    • Use a dedicated EmitContext for _variant_get*() functions
    • (0.52.10) gtkmodule: Handle nested closure elements and bind them accordingly [#1262]
  • vala:
    • NullLiteral is not a valid argument for string concatenation [#1260]
    • Set is_yield_expression in async context when chaining up to async base ctor
    • Report statement parsing error if it is not meant to be an expression [#1261]
    • girparser: Avoid possibily creating duplicated attributes
  • vapigen.m4: use $PKG_CONFIG_SYSROOT_DIR

Bindings:

  • glib-2.0: Always use the actual C type for CCode.array_length_type
  • gstreamer: Cherry-pick bindings fixes from 0.56
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: xfce The Xfce Desktop Environment label Jan 10, 2022
@bobby285271
Copy link
Member Author

bobby285271 commented Jan 10, 2022 •
edited
Loading

@ofborg build vala_0_48 vala_0_52
@ofborg build vala_0_40 ping xfce.xfce4-namebar-plugin

bobby285271
bobby285271 commented Jan 10, 2022
View reviewed changes
pkgs/applications/networking/ping/default.nix
@@ -14,7 +15,6 @@
, libsoup
, libgee
, wrapGAppsHook
, vala_0_40
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vala is still in args.

bobby285271
bobby285271 commented Jan 10, 2022
View reviewed changes
pkgs/development/compilers/vala/default.nix
@@ -15,19 +15,7 @@ let
# header file isn't available at all, but that patch (./gvc-compat.patch)
# can be shared between all versions of Vala so far.
graphvizPatch =
let
fp = { commit, sha256 }: fetchpatch {
Copy link
Member Author

@bobby285271 bobby285271 Jan 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is only needed for vala 0.38 and 0.42.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal was to avoid having to maintain the patch ourselves. But in the end we had to because openembedded was too slow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that the patch has been removed in openembedded/openembedded-core@dc4555d. So maybe we have to maintain ourselves if we don't switch to --disable-valadoc?

@bobby285271 bobby285271 marked this pull request as ready for review January 10, 2022 09:03
romildo
romildo approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xfce.xfce4-namebar-plugin LGTM

@bobby285271
Copy link
Member Author

bobby285271 commented Jan 17, 2022 •
edited
Loading

Anything I should do before merging this? 😂

@jtojnar jtojnar merged commit 0b3e6e3 into NixOS:master Jan 17, 2022
@jtojnar
Copy link
Member

jtojnar commented Jan 17, 2022

Sorry, forgot about this. Looks good, thanks.

@bobby285271 bobby285271 deleted the vala branch January 18, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romildo romildo romildo approved these changes

@davidak davidak Awaiting requested review from davidak

@xiorcale xiorcale Awaiting requested review from xiorcale

@amaxine amaxine Awaiting requested review from amaxine

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: xfce The Xfce Desktop Environment 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobby285271 @jtojnar @romildo