Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rssh: init at 2.3.4 #15427

Merged
merged 1 commit into from
May 16, 2016
Merged

rssh: init at 2.3.4 #15427

merged 1 commit into from
May 16, 2016

Conversation

Shados
Copy link
Member

@Shados Shados commented May 13, 2016

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Some caveats and notes:

  • I have only tested this with rsync, scp, and sftp. cvs support should work, but rssh's chroot integration is unlikely to function without further work (which I'm not motivated to do, as it is not relevant for my use-case).
  • It is compiled without rdist support because rdist is ludicrously ancient (and not already packaged).
  • Except one, the patches are from the AUR PKGBUILD for rssh, required as the upstream project is no longer actively maintained.

./0006-mkchroot-symlink.patch
./0007-destdir.patch
./0008-rsync-protocol.patch
./fix-config-path.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to source the patches from AUR directly ? there are quite a few patches and we are trying to avoid nixpkgs becoming too big

@zimbatm
Copy link
Member

zimbatm commented May 13, 2016

thanks, can you add a note in the default.nix for the missing support ?

@Shados
Copy link
Member Author

Shados commented May 16, 2016

@zimbatm Done that, and changed to use fetchurl to grab the AUR patches.

@zimbatm zimbatm merged commit c276727 into NixOS:master May 16, 2016
@zimbatm
Copy link
Member

zimbatm commented May 16, 2016

Perfect, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants