Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guile-sdl2 package to nixpkgs #15478

Merged
merged 1 commit into from
May 15, 2016
Merged

Conversation

seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented May 15, 2016

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Reguarding sandboxing: I cannot find it in the manual link you provided, sorry.

@joachifm
Copy link
Contributor

If you're on an older version of NixOS, the option you want is nix.useChroot

@zimbatm
Copy link
Member

zimbatm commented May 15, 2016

To fit the CONTRIBUTING the commit should be named: guile-sdl2: init at 0.1.0

pkgconfig ];
src = fetchgit {
url = "git://dthompson.us/guile-sdl2.git";
rev = "048f80ddb5c6b03b87bba199a99a6f22d911bfff";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also use a git tag as a reference: rev = "v${version}";

@seppeljordan
Copy link
Contributor Author

@zimbatm sorry i am missing something, but isn't that what i named my commit?

@zimbatm
Copy link
Member

zimbatm commented May 15, 2016

my bad, i assumed the PR title was the same as the commit name

@pSub pSub added the 8.has: package (new) This PR adds a new package label May 15, 2016
@seppeljordan
Copy link
Contributor Author

@zimbatm would it be okay if i amend the commit, or should i make a new one to incorporate your suggestions?

@zimbatm
Copy link
Member

zimbatm commented May 15, 2016

amending is cool

On Sun, 15 May 2016 at 15:11 Sebastian Jordan notifications@github.com
wrote:

@zimbatm https://github.com/zimbatm would it be okay if i amend the
commit, or should i make a new one to incorporate your suggestions?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#15478 (comment)

@seppeljordan seppeljordan force-pushed the guile-sdl2 branch 2 times, most recently from 0b6a945 to 0f68212 Compare May 15, 2016 15:11
@seppeljordan
Copy link
Contributor Author

I thinks it is ready now.

@@ -328,6 +328,7 @@
schmitthenner = "Fabian Schmitthenner <development@schmitthenner.eu>";
schristo = "Scott Christopher <schristopher@konputa.com>";
scolobb = "Sergiu Ivanov <sivanov@colimite.fr>";
sebastianjordan = "Sebastian Jordan <sebastian.jordan.mail@googlemail.com>";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the left hand side should be your github handle. the idea is to make it easier to contact you when an issue is opened against the package.

@seppeljordan
Copy link
Contributor Author

changed my entry in maintainers.nix to conform the standards.

@zimbatm zimbatm merged commit 0d09437 into NixOS:master May 15, 2016
@zimbatm
Copy link
Member

zimbatm commented May 15, 2016

Perfect, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants