-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guile-sdl2 package to nixpkgs #15478
Conversation
If you're on an older version of NixOS, the option you want is |
To fit the CONTRIBUTING the commit should be named: |
pkgconfig ]; | ||
src = fetchgit { | ||
url = "git://dthompson.us/guile-sdl2.git"; | ||
rev = "048f80ddb5c6b03b87bba199a99a6f22d911bfff"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can also use a git tag as a reference: rev = "v${version}";
@zimbatm sorry i am missing something, but isn't that what i named my commit? |
my bad, i assumed the PR title was the same as the commit name |
@zimbatm would it be okay if i amend the commit, or should i make a new one to incorporate your suggestions? |
amending is cool On Sun, 15 May 2016 at 15:11 Sebastian Jordan notifications@github.com
|
0b6a945
to
0f68212
Compare
I thinks it is ready now. |
@@ -328,6 +328,7 @@ | |||
schmitthenner = "Fabian Schmitthenner <development@schmitthenner.eu>"; | |||
schristo = "Scott Christopher <schristopher@konputa.com>"; | |||
scolobb = "Sergiu Ivanov <sivanov@colimite.fr>"; | |||
sebastianjordan = "Sebastian Jordan <sebastian.jordan.mail@googlemail.com>"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the left hand side should be your github handle. the idea is to make it easier to contact you when an issue is opened against the package.
changed my entry in maintainers.nix to conform the standards. |
Perfect, thanks ! |
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)Reguarding sandboxing: I cannot find it in the manual link you provided, sorry.