Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpinyin: 2.3.0 -> 2.6.1 #155785

Merged
merged 1 commit into from
Jan 24, 2022
Merged

libpinyin: 2.3.0 -> 2.6.1 #155785

merged 1 commit into from
Jan 24, 2022

Conversation

linsui
Copy link
Contributor

@linsui linsui commented Jan 20, 2022

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ericsagnes

@linsui linsui requested a review from jonringer January 20, 2022 04:42
bobby285271
bobby285271 approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@bobby285271 bobby285271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#155807 (review)

@marsam marsam merged commit 9114e8b into NixOS:master Jan 24, 2022
@linsui linsui deleted the libpinyin branch January 24, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobby285271 bobby285271 bobby285271 approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linsui @bobby285271 @marsam