Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo: Init at 1.2 #15705

Merged
merged 1 commit into from
May 26, 2016
Merged

redo: Init at 1.2 #15705

merged 1 commit into from
May 26, 2016

Conversation

vrthra
Copy link
Member

@vrthra vrthra commented May 25, 2016

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Redo is an alternative for Make. This package is a C++ implementation
of redo.

@joachifm joachifm added the 8.has: package (new) This PR adds a new package label May 25, 2016

nativeBuildInputs = [ perl /* for pod2man */ ];

unpackPhase = ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that the archive just dumps all the files into the current directory? If so, you can try setting sourceRoot = "." and use the default unpack phase instead. If you prefer to use a custom unpack phase, you should do something like mkdir $name && tar xf $src -C $name && cd $name instead, IMO.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joachifm fixed this as you suggested (sourceRoot = .)

Redo is an alternative for Make. This package is a C++ implementation
of redo.
@joachifm
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants