Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.X11XCB no longer builds. Holds back nixos-unstable. #15771

Closed
obadz opened this issue May 28, 2016 · 8 comments
Closed

perlPackages.X11XCB no longer builds. Holds back nixos-unstable. #15771

obadz opened this issue May 28, 2016 · 8 comments

Comments

@obadz
Copy link
Contributor

obadz commented May 28, 2016

Fails on d140dee for instance:

$ nix-build '<nixpkgs>' -A perlPackages.X11XCB
…
In file included from /nix/store/d13sw23db0sp2pgnxvc8v12nrj33b7d5-libxcb-1.12-dev/include/xcb/xcb.h:193:0,
                 from XCB.xs:4:
/nix/store/d13sw23db0sp2pgnxvc8v12nrj33b7d5-libxcb-1.12-dev/include/xcb/xproto.h:11887:1: note: declared here
 xcb_change_keyboard_control (xcb_connection_t *c,
 ^
Makefile:397: recipe for target 'XCB.o' failed
make: *** [XCB.o] Error 1
builder for ‘/nix/store/hxnk52xa2ldjsfd3qblm8cjy48cbl60x-perl-X11-XCB-0.14.drv’ failed with exit code 2
error: build of ‘/nix/store/hxnk52xa2ldjsfd3qblm8cjy48cbl60x-perl-X11-XCB-0.14.drv’ failed

Test failing:

$ nix-build '<nixos/release.nix>' -A tests.i3wm.x86_64-linux

Upgrading perlPackages.X11XCB to 0.15 _does not_ fix it:

diff --git a/pkgs/top-level/perl-packages.nix b/pkgs/top-level/perl-packages.nix
index db1405f..00d0cc9 100644
--- a/pkgs/top-level/perl-packages.nix
+++ b/pkgs/top-level/perl-packages.nix
@@ -13981,10 +13981,10 @@ let self = _self // overrides; _self = with self; {
   };

   X11XCB = buildPerlPackage rec {
-    name = "X11-XCB-0.14";
+    name = "X11-XCB-0.15";
     src = fetchurl {
       url = "mirror://cpan/authors/id/M/MS/MSTPLBG/${name}.tar.gz";
-      sha256 = "11ff0a4nqbdj68mxdvyqdqvi573ha10vy67wpi7mklpxvlm011bn";
+      sha256 = "10fflr91bl2hi3maa0qirdf0ahqpdkn6j89waj6y0qcad53i0lm5";
     };
     AUTOMATED_TESTING = false;
     buildInputs = [

Reverting upgardes to libxcb (part of @vcunat's 69ed132) _does_ fix:

diff --git a/pkgs/servers/x11/xorg/default.nix b/pkgs/servers/x11/xorg/default.nix
index 16fa242..95085be 100644
--- a/pkgs/servers/x11/xorg/default.nix
+++ b/pkgs/servers/x11/xorg/default.nix
@@ -1041,11 +1041,11 @@ let
   }) // {inherit ;};

   libxcb = (mkDerivation "libxcb" {
-    name = "libxcb-1.12";
+    name = "libxcb-1.11.1";
     builder = ./builder.sh;
     src = fetchurl {
-      url = http://xcb.freedesktop.org/dist/libxcb-1.12.tar.bz2;
-      sha256 = "0nvv0la91cf8p5qqlb3r5xnmg1jn2wphn4fb5jfbr6byqsvv3psa";
+      url = http://xcb.freedesktop.org/dist/libxcb-1.11.1.tar.bz2;
+      sha256 = "0c4xyvdyx5adh8dzyhnrmvwwz24gri4z1czxmxqm63i0gmngs85p";
     };
     buildInputs = [pkgconfig libxslt libpthreadstubs python libXau xcbproto libXdmcp ];
     meta.platforms = stdenv.lib.platforms.unix;
@@ -1327,11 +1327,11 @@ let
   }) // {inherit ;};

   xcbproto = (mkDerivation "xcbproto" {
-    name = "xcb-proto-1.12";
+    name = "xcb-proto-1.11";
     builder = ./builder.sh;
     src = fetchurl {
-      url = http://xcb.freedesktop.org/dist/xcb-proto-1.12.tar.bz2;
-      sha256 = "01j91946q8f34l1mbvmmgvyc393sm28ym4lxlacpiav4qsjan8jr";
+      url = http://xcb.freedesktop.org/dist/xcb-proto-1.11.tar.bz2;
+      sha256 = "0bp3f53l9fy5x3mn1rkj1g81aiyzl90wacwvqdgy831aa3kfxb5l";
     };
     buildInputs = [pkgconfig python ];
     meta.platforms = stdenv.lib.platforms.unix;
@@ -1349,11 +1349,11 @@ let
   }) // {inherit gperf m4 libxcb xproto ;};

   xcbutilcursor = (mkDerivation "xcbutilcursor" {
-    name = "xcb-util-cursor-0.1.3";
+    name = "xcb-util-cursor-0.1.2";
     builder = ./builder.sh;
     src = fetchurl {
-      url = http://xcb.freedesktop.org/dist/xcb-util-cursor-0.1.3.tar.bz2;
-      sha256 = "0krr4rcw6r42cncinzvzzdqnmxk3nrgpnadyg2h8k9x10q3hm885";
+      url = http://xcb.freedesktop.org/dist/xcb-util-cursor-0.1.2.tar.bz2;
+      sha256 = "0fpv46zb7kz04qxwvpax4cpd2kd8yhsm2n0if1isniqdh5xkcrgd";
     };
     buildInputs = [pkgconfig gperf m4 libxcb xcbutilimage xcbutilrenderutil xproto ];
     meta.platforms = stdenv.lib.platforms.unix;
diff --git a/pkgs/servers/x11/xorg/extra.list b/pkgs/servers/x11/xorg/extra.list
index 56a7b1f..fc3068b 100644
--- a/pkgs/servers/x11/xorg/extra.list
+++ b/pkgs/servers/x11/xorg/extra.list
@@ -1,8 +1,8 @@
 http://xcb.freedesktop.org/dist/libpthread-stubs-0.3.tar.bz2
-http://xcb.freedesktop.org/dist/libxcb-1.12.tar.bz2
-http://xcb.freedesktop.org/dist/xcb-proto-1.12.tar.bz2
+http://xcb.freedesktop.org/dist/libxcb-1.11.1.tar.bz2
+http://xcb.freedesktop.org/dist/xcb-proto-1.11.tar.bz2
 http://xcb.freedesktop.org/dist/xcb-util-0.4.0.tar.bz2
-http://xcb.freedesktop.org/dist/xcb-util-cursor-0.1.3.tar.bz2
+http://xcb.freedesktop.org/dist/xcb-util-cursor-0.1.2.tar.bz2
 http://xcb.freedesktop.org/dist/xcb-util-image-0.4.0.tar.bz2
 http://xcb.freedesktop.org/dist/xcb-util-keysyms-0.4.0.tar.bz2
 http://xcb.freedesktop.org/dist/xcb-util-renderutil-0.3.9.tar.bz2
@vcunat
Copy link
Member

vcunat commented May 28, 2016

I had tried to fix it by upgrading. The perl package apparently uses non-public functions. I had filed a bug on CPAN, though I don't know if that was a good place: https://rt.cpan.org/Public/Bug/Display.html?id=114732 In nixpkgs the only dependant is i3. We might resurrect old libxcb and keep a copy, I suppose.

@vcunat
Copy link
Member

vcunat commented May 28, 2016

/cc @garbas, @modulistic: perhaps it's possible this perl package isn't too important for i3?

@vcunat
Copy link
Member

vcunat commented May 28, 2016

BTW, this isn't the only problem blocking the unstable* channels from security update – container tests are also broken and there I have no clue about cause or solution. (EDIT: well I do suspect systemd update might be the commit causing it.)

@garbas
Copy link
Member

garbas commented May 29, 2016

i'll take a look at the morning ... might be that this perl package is not needed anymore.

@vcunat
Copy link
Member

vcunat commented May 29, 2016

@garbas: the upstream maintainer committed a fix; see discussion at stapelberg/X11-XCB#1

@stapelberg
Copy link
Contributor

X11::XCB 0.16 was just released with a fix.

@vcunat vcunat closed this as completed in b7c38c7 May 29, 2016
@vcunat
Copy link
Member

vcunat commented May 29, 2016

I tested also that i3 builds again.

@garbas
Copy link
Member

garbas commented May 29, 2016

tnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants