-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker #1581
Add docker #1581
Conversation
meh wrong rebase, just a second |
Also nixos module should be made, docker plays nicely with systemd. Report any problems you have, i just made a basic smoke test. |
@@ -6369,6 +6369,7 @@ let | |||
|
|||
apparmor = callPackage ../os-specific/linux/apparmor { | |||
inherit (perlPackages) LocaleGettext TermReadKey RpcXML; | |||
bison = bison2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this related to docker change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker needs lxc, and lxc does not build without this change, because apparmor does not build with new bison(just look in hydra, failing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quoting Jaka Hudoklin (2014-01-25 09:08:05)
In pkgs/top-level/all-packages.nix:
@@ -6369,6 +6369,7 @@ let
apparmor = callPackage ../os-specific/linux/apparmor {
inherit (perlPackages) LocaleGettext TermReadKey RpcXML;
- bison = bison2;
Docker needs lxc, and lxc does not build without this change.
k, didn't new this. i though it slipped into this pull request.
+1 ... awesome can't wait to try it ;) |
i sent you xtruder/pull/1 to fix above issue when running docker as a user i get
is this something we need to fix in package? or we need to create nixos service? |
We need nixos service. You first need to start docker daemon with "sudo docker -d" and then you can run docker. I haven't made nixos service yet. |
Thx for the patch :) |
Ok i rebased it, i also added zsh and bash autocompletion functions and systemd service, so you can easily make nixos module :) |
Awesome! |
No description provided.