dart: 0.4 -> 1.16.1

[jirkadanek]

Motivation for this change

Things done

• Tested using sandboxing
  (nix.useSandbox on NixOS,
  or option build-use-sandbox in nix.conf
  on non-NixOS)
• Built on platform(s)
  • NixOS
  • OS X
  • Linux
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

Update to the original PR #468. Package is still based on binary release.

I've been working with it for a day and it seems to be working. It is my first package,
so if you have any comments and suggestions for improvements, would be
glad to hear them.

[mention-bot]

By analyzing the blame information on this pull request, we identified @zefhemel, @gridaphobe and @jwiegley to be potential reviewers

[groxxda]

• No need to add unzip as a dependency and explicitly call it in unpackPhase.
  The default unpackPhase will try to figure out the archive type and should do everything automagically for you if you set the src attribute of the derivation. (either move it down into mkDerivation { or use inherit src inside mkDerivation)
• I think the assertion for system can be replaced with meta.platforms = [ "i686-linux" "x86_64-linux" ]

[jirkadanek]

@groxxda default unpackPhase does not unzip it for me,

$ nix-env -f nixpkgs -i dart
replacing old ‘dart-1.16.1’
installing ‘dart-1.16.1’
download-from-binary-cache.pl: still waiting for ‘https://cache.nixos.org/i4fv222893f2dybhvxd19308z1sns8rx.narinfo’ after 5 seconds...
these derivations will be built:
/nix/store/a4zqnx92bj58j4c9mhyyxjl4q6bk5qdg-dart-1.16.1.drv
building path(s) ‘/nix/store/i4fv222893f2dybhvxd19308z1sns8rx-dart-1.16.1’
unpacking sources
unpacking source archive /nix/store/bpi2j1gri3w3hrxfw0zk132fvw6g2kfh-dartsdk-linux-x64-release.zip
do not know how to unpack source archive /nix/store/bpi2j1gri3w3hrxfw0zk132fvw6g2kfh-dartsdk-linux-x64-release.zip
builder for ‘/nix/store/a4zqnx92bj58j4c9mhyyxjl4q6bk5qdg-dart-1.16.1.drv’ failed with exit code 1
error: build of ‘/nix/store/a4zqnx92bj58j4c9mhyyxjl4q6bk5qdg-dart-1.16.1.drv’ failed

Looking at https://github.com/NixOS/nixpkgs/blob/master/pkgs/stdenv/generic/setup.sh#L497 suggests that it does not know about zips.

[groxxda]

Sorry - you have to add unzip to buildInputs or better nativeBuildInputs. Unpacking should then happen without explicitly setting unpackPhase. Thanks to unzip/setup-hook.sh

[jirkadanek]

So much magic ;) I fixed it according to your suggestions.

[joachifm]

To make updating more convenient, you could add a separate version attribute and re-use it both in the name and in the source urls below.

[jirkadanek]

done