Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duc: 1.3.3 -> 1.4.1 #15999

Merged
merged 1 commit into from
Jun 6, 2016
Merged

duc: 1.3.3 -> 1.4.1 #15999

merged 1 commit into from
Jun 6, 2016

Conversation

womfoo
Copy link
Member

@womfoo womfoo commented Jun 5, 2016

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @lethalman and @joachifm to be potential reviewers

@FRidh
Copy link
Member

FRidh commented Jun 5, 2016

cc @lethalman

@FRidh FRidh added the 8.has: package (update) This PR updates a package to a newer version label Jun 5, 2016
@womfoo
Copy link
Member Author

womfoo commented Jun 5, 2016

weird. this builds locally on unstable and nox on my machine

[kranium@silverspark:~]$ nox-review pr 15999
=== Reviewing PR 15999 : duc: 1.3.3 -> 1.4.1
==> Fetching base (master)
==> Fetching PR
==> Fetching extra history for merging
==> Merging PR into base
Building in /tmp/nox-review-vmiwaapo: duc
/nix/store/6jww138afxnv2gsaab0sbvvvc2r7yf60-duc-1.4.1
Result in /tmp/nox-review-vmiwaapo
total 0
lrwxrwxrwx 1 kranium users 53 Jun  6 06:01 result -> /nix/store/6jww138afxnv2gsaab0sbvvvc2r7yf60-duc-1.4.1

@lucabrunox lucabrunox merged commit 5428a29 into NixOS:master Jun 6, 2016
@lucabrunox
Copy link
Contributor

Built locally, thanks.

@womfoo womfoo deleted the duc branch June 11, 2016 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants