Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elixir: 1.2.5 -> 1.2.6 #16037

Merged
merged 1 commit into from
Jun 7, 2016
Merged

elixir: 1.2.5 -> 1.2.6 #16037

merged 1 commit into from
Jun 7, 2016

Conversation

couchemar
Copy link
Contributor

Motivation for this change

Update elixir version.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Also ejabberd-deps outputHash is updated.

I'm not an ejabberd user, so i interested in reasons why ejabberd with elixir is marked as broken? (cc @abbradar)

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @zimbatm, @dezgeg and @abbradar to be potential reviewers

@abbradar
Copy link
Member

abbradar commented Jun 7, 2016

I think there were compilation errors but I don't quite remember. It's not nice that change in elixir provokes a change in this hash, I'll look into it later.

@zimbatm
Copy link
Member

zimbatm commented Jun 7, 2016

output path ‘/nix/store/5hyiq0gm437day6dfb8dbdknbwd7ysg3-ejabberd-deps-16.04’ has r:sha256 hash ‘1p6qx15asmgixsdysaidcc5vyw73qp6pd5g9pl66dkkzgvgq9nxa’ when ‘0jrxd3v6p35wjrpw0jbb6m8nrm2lffhfgdcqmzcvsvjzji7nlkzx’ was expected

@abbradar
Copy link
Member

abbradar commented Jun 7, 2016

Ouch... this likely shows that ejabberd-deps is not deterministic. I'll try to look into this later, but don't have time right now. Completely not this package's fault, though.

@abbradar abbradar added the 8.has: package (update) This PR updates a package to a newer version label Jun 7, 2016
@zimbatm zimbatm merged commit 5811b47 into NixOS:master Jun 7, 2016
@zimbatm
Copy link
Member

zimbatm commented Jun 7, 2016

Right, the rest of the dependencies (hex2nix and elixir) built fine

@abbradar abbradar mentioned this pull request Jun 15, 2016
7 tasks
@couchemar couchemar deleted the elixir-1.2.6 branch March 6, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants