weka: 3.6.12 -> 3.8.0 #16055
Closed
weka: 3.6.12 -> 3.8.0 #16055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "weka-${version}"; | ||
| version = "3-8-0"; |
There was a problem hiding this comment.
Please use 3.8.0; to reduce duplication, you can do replaceChars ["."] ["-"].
joachifm
added
the
8.has: package (update)
|
Other than my note, this looks superficially okay to me. |
|
Thanks @joachifm for the advise. I think is ready now. |
|
@joachifm, I've noticed that this package hasn't a maintainer. Could be I one? I'm very new to NixOS but I think one newbie is better than no one. |
|
@mimadrid that'd be great. All that is required to be a maintainer is caring about the package. |
|
Pushed to master. Thank you. |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pull request to NixOS so I hope that I have done it well.
Motivation for this change
Update weka to the last stable version.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)