Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atom: patchelf ctags binary #16056

Merged
merged 1 commit into from
Jun 8, 2016
Merged

atom: patchelf ctags binary #16056

merged 1 commit into from
Jun 8, 2016

Conversation

ljli
Copy link
Contributor

@ljli ljli commented Jun 7, 2016

Motivation for this change

Included ctags support is broken

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Should fix #15528

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @offlinehacker, @abbradar and @travisbhartwell to be potential reviewers

@rushmorem
Copy link
Contributor

nix-shell -p nox --run "nox-review pr 16056" builds fine. Thanks.

@rushmorem rushmorem merged commit 5c8a880 into NixOS:master Jun 8, 2016
@ljli ljli deleted the fix-atom branch June 8, 2016 18:53
@Gerschtli Gerschtli mentioned this pull request Jun 10, 2018
8 tasks
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

atom editor ships ctags as unpatched elf file
4 participants