Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshot-qt: add new package, version 2.0.7 #16098

Merged
merged 2 commits into from Jul 17, 2016
Merged

openshot-qt: add new package, version 2.0.7 #16098

merged 2 commits into from Jul 17, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jun 9, 2016

Motivation for this change

add free video editor openshot-qt and dependencies required for build

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@@ -0,0 +1,48 @@
{stdenv, fetchurl, fetchFromGitHub, callPackage, makeWrapper, doxygen
, ffmpeg, python3, python3Packages, qt55}:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python3 comes with python3Packages, so please drop python3 here.

@FRidh
Copy link
Member

FRidh commented Jul 17, 2016

Thanks for the PR. Apologies for reviewing it this late.
Could you put unittest-cpp in a separate commit and name the commits according to the contributing guidelines.

@FRidh FRidh added 2.status: work-in-progress This PR isn't done 8.has: package (new) This PR adds a new package labels Jul 17, 2016
@FRidh
Copy link
Member

FRidh commented Jul 17, 2016

oh and cc me when that's done. It looks like it is to be ready to merged then.

@ghost
Copy link
Author

ghost commented Jul 17, 2016 via email

@ghost
Copy link
Author

ghost commented Jul 17, 2016 via email

@FRidh
Copy link
Member

FRidh commented Jul 17, 2016

I tried and did not figure it out. Also I haven't found any example of
doing this with PYTHONPATH, it is always without makeLibraryPath.

You're correct. I thought it could be used also for this case but apparently it can't.

Testing now.

@FRidh
Copy link
Member

FRidh commented Jul 17, 2016

Indeed, there is a issue with PyQt5. See #17045

@FRidh FRidh merged commit abf7475 into NixOS:master Jul 17, 2016
@FRidh FRidh removed the 2.status: work-in-progress This PR isn't done label Jul 17, 2016
@ghost
Copy link
Author

ghost commented Jul 17, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant