-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openshot-qt: add new package, version 2.0.7 #16098
Conversation
@@ -0,0 +1,48 @@ | |||
{stdenv, fetchurl, fetchFromGitHub, callPackage, makeWrapper, doxygen | |||
, ffmpeg, python3, python3Packages, qt55}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python3 comes with python3Packages, so please drop python3 here.
Thanks for the PR. Apologies for reviewing it this late. |
oh and cc me when that's done. It looks like it is to be ready to merged then. |
Hi Frederik,
python3 comes with python3Packages, so please drop python3 here.
fixed
${python3}/bin/python3 -> ${python.interpreter}
fixed
you can use here stdenv.lib.makeLibraryPath
I tried and did not figure it out. Also I haven't found any example of
doing this with PYTHONPATH, it is always without makeLibraryPath.
Thanks for the PR. Apologies for reviewing it this late.
I thank you for your time and help!
Could you put unittest-cpp in a separate commit
fixed
and name the commits according to the contributing guidelines.
fixed
oh and cc me when that's done. It looks like it is to be ready to
merged then.
I implemented your suggestions, built and tested openshot-qt and it
worked fine. Then I rebased on top of master and after that I get the
following error:
…-- Detecting CXX compile features
Error: Failed to determine the detail of your Qt installation. Try again
using
the --verbose flag to see more detail about the problem.
Querying qmake about your Qt installation...
Determining the details of your Qt installation...
/nix/store/517s8rgjl7yda8s3kfzlxnp0zapsix13-qtbase-5.5.1-dev/bin/qmake
-o qtdetail.mk qtdetail.pro
Could not find qmake configuration file linux-g++.
Error processing project file: qtdetail.pro
builder for
‘/nix/store/dqbdd8fl5dhc6jshfzvz3hq4xfm39ixr-python3.5-PyQt-5.5.1.drv’
failed with exit code 1
cannot build derivation
‘/nix/store/fsqnnbhwg4p2f67ijampxqzw7hcd11w0-openshot-qt-2.0.7.drv’: 1
dependencies couldn't be built
error: build of
‘/nix/store/fsqnnbhwg4p2f67ijampxqzw7hcd11w0-openshot-qt-2.0.7.drv’
failed
This looks like a problem with the HEAD in python3.5-PyQt-5.5.1. I have
no idea what to do about this and I think this is out of scope for the
openshot-qt nix package.
|
cc @FRidh
|
You're correct. I thought it could be used also for this case but apparently it can't. Testing now. |
Indeed, there is a issue with PyQt5. See #17045 |
Merged #16098.
Thanks a lot!
|
Motivation for this change
add free video editor openshot-qt and dependencies required for build
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)