Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GnuTLS: 3.4.11 -> 3.4.13 / GnuTLS35: init -> 3.5.1 #16360

Merged
merged 2 commits into from
Jun 29, 2016

Conversation

leenaars
Copy link
Contributor

@leenaars leenaars commented Jun 20, 2016

Motivation for this change

GnuTLS 3.5 is the new stable-next branch, which is appearing as a dependency. GnuTLS 3.4.13 is a bug fix release on the current stable branch, with security advisory GnuTLS-SA-2016-1 attached to it.

Note that a new test for GnuTLS requires the use of netstat for both, which is part of nettools. Therefore this is added as a dependency on generic.nix.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @edolstra, @wkennington and @vcunat to be potential reviewers

@vcunat
Copy link
Member

vcunat commented Jun 20, 2016

Note: the advisory says only 3.4.12 is affected, so I'm not marking 11->13 as security update.

@leenaars
Copy link
Contributor Author

After building on NixOS, I noticed some impurity: one of the (new) tests required needed a shell, which was added and squashed into the commit.

@leenaars leenaars force-pushed the gnutlsupdate branch 2 times, most recently from b513de7 to 44d6280 Compare June 20, 2016 23:02
@joachifm joachifm added the 8.has: package (update) This PR updates a package to a newer version label Jun 22, 2016
vcunat added a commit that referenced this pull request Jun 25, 2016
@vcunat vcunat merged commit 2cf31a1 into NixOS:master Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants