-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wolfssl: 3.9.0 -> 3.9.6, split package #16389
Conversation
By analyzing the blame information on this pull request, we identified @zimbatm to be a potential reviewer |
postInstall = '' | ||
# fix recursive cycle: | ||
# wolfssl-config points to dev, dev propagates bin | ||
rm $bin/bin/wolfssl-config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does moveToOutput bin/wolfssl-config "$dev"
work? (similar is used by e.g. curl)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion - I'll check this out...
33afa99
to
c227201
Compare
Updated patch now using moveToOuptut on bin/wolfssl-config rather than deleting it. Because there is nothing else in $out besides this file, moveToOutput ends up removing $out itself causing the build to fail. Possibly moveToOutput could be fixed not to do so, but there wasn't an obvious way to do this, and since this situation is pretty rare anyway, I've simply decided to do a quick Is this an acceptable approach? |
Thanks so much for the quick merge, @zimbatm! |
👍 nice work too! |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)Note that no package immediately depends on wolfssl, so for testing I've built curl with wolfssl as a replacement for openssl using the following nix shell script:
The resulting curl binary was tested with
which work as expected (the latter command gives
curl: (35) CyaSSL does not support SSLv2
confirming that it indeed uses wolfssl).Note that I had to break a dependency cycle. I did this simply by removing the "wolfssl-config" binary. The dev package comes with a pkg-config .pc file anyway, so I hope this is an acceptable solution. If there is a more standard solution for this problem, I'd be happy to be pointed to it and to fix it accordingly.