Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rawtherapee: 4.0 -> 4.2 #16488

Merged
merged 1 commit into from
Jul 5, 2016
Merged

rawtherapee: 4.0 -> 4.2 #16488

merged 1 commit into from
Jul 5, 2016

Conversation

2chilled
Copy link
Contributor

Motivation for this change

Want to use the hottest raw features

Things done
  • Tested using sandboxing
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @viric and @vcunat to be potential reviewers

@joachifm joachifm added the 8.has: package (update) This PR updates a package to a newer version label Jun 25, 2016

enableParallelBuilding = true;

meta = {
description = "RAW converter and digital photo processing software";
homepage = http://www.rawtherapee.com/;
license = stdenv.lib.licenses.gpl3Plus;
maintainers = with stdenv.lib.maintainers; [viric jcumming];
maintainers = with stdenv.lib.maintainers; [viric jcumming mahe];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is mahe you? Ideally, the handle in maintainers should match your github. An older alias perhaps?

@vcunat vcunat merged commit 392448b into NixOS:master Jul 5, 2016
vcunat added a commit that referenced this pull request Jul 5, 2016
@vcunat
Copy link
Member

vcunat commented Jul 5, 2016

Oh, I wasn't paying attention and merged without much thinking. Those are all good comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants