Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcptrack: 1.4.2 -> 1.4.3 #16508

Merged
merged 1 commit into from
Jun 26, 2016
Merged

tcptrack: 1.4.2 -> 1.4.3 #16508

merged 1 commit into from
Jun 26, 2016

Conversation

vrthra
Copy link
Member

@vrthra vrthra commented Jun 26, 2016

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @bjornfor and @vcunat to be potential reviewers

@pSub pSub added the 8.has: package (update) This PR updates a package to a newer version label Jun 26, 2016
@@ -16,9 +17,9 @@ stdenv.mkDerivation rec {

meta = with stdenv.lib; {
description = "libpcap based program for live TCP connection monitoring";
homepage = http://www.rhythm.cx/~steve/devel/tcptrack/; # dead link
homepage = http://github.com/bchretien/tcptrack;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also do inherit (src.meta) homepage

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joachifm updated.

@joachifm joachifm merged commit ee6dd13 into NixOS:master Jun 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants