Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.dns: 1.12.0 -> 1.14.0 #16534

Merged
merged 1 commit into from
Jun 27, 2016
Merged

Conversation

fpletz
Copy link
Member

@fpletz fpletz commented Jun 26, 2016

Motivation for this change

Adds support for both python 2 & 3 from one codebase.

This might break some packages that depend on the old python3 version module naming dnspython3.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fpletz fpletz added 6.topic: python 8.has: package (update) This PR updates a package to a newer version labels Jun 26, 2016
@FRidh
Copy link
Member

FRidh commented Jun 27, 2016

Please use an archive from PyPI.
https://pypi.io/project/dnspython/#files

Adds support for both python 2 & 3 from one codebase.
@fpletz
Copy link
Member Author

fpletz commented Jun 27, 2016

Oh, yeah! Thanks, done.

@fpletz fpletz mentioned this pull request Jun 27, 2016
7 tasks
@fpletz fpletz merged commit 2e68b65 into NixOS:master Jun 27, 2016
@fpletz fpletz deleted the pkgs/dnspython branch June 27, 2016 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants