Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick: init at 1.4.0 #16593

Merged
merged 1 commit into from
Jul 2, 2016
Merged

pick: init at 1.4.0 #16593

merged 1 commit into from
Jul 2, 2016

Conversation

womfoo
Copy link
Member

@womfoo womfoo commented Jun 29, 2016

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

description = "Fuzzy text selection utility";
license = licenses.mit;
maintainers = [ maintainers.womfoo ];
platforms = platforms.linux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/thoughtbot/pick says it builds on OSX too? isn't linux too restrictive?

@womfoo
Copy link
Member Author

womfoo commented Jun 30, 2016

Hey @vrthra while I use nixos on a macbook, I still try to avoid OSX ;-)

Anyways, the package has simple deps so I'm ok in maintaining this additional platform.

Tested and rebased the commit with OSX.

@joachifm joachifm merged commit 648ae73 into NixOS:master Jul 2, 2016
@womfoo womfoo deleted the init/pick-1.4.0 branch July 6, 2016 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants