Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gtk : Enable wayland support on Linux #16617

Merged
merged 1 commit into from
Jul 1, 2016
Merged

Conversation

thufschmitt
Copy link
Member

Motivation for this change

Gtk3 is currently compiled without wayland support.
This pr enables it by default on Linux, (as it is already done in most other distributions).

I haven't tested it much, except on the packages I use, because I don't have the build power to rebuild the whole dependency closure of gtk3 (but I hope this won't bring much trouble, as the wayland backend is only supposed to be active if the GDK_BACKEND env var is set to wayland).

Note: This triggers quite a huge rebuild, should I submit the pull request to staging instead ?

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @vcunat, @spwhitt and @urkud to be potential reviewers

@vcunat vcunat added the 1.severity: mass-rebuild This PR causes a large number of packages to rebuild label Jun 30, 2016
@vcunat vcunat self-assigned this Jun 30, 2016
@vcunat
Copy link
Member

vcunat commented Jun 30, 2016

Staged.

@vcunat vcunat merged commit d756aee into NixOS:master Jul 1, 2016
@thufschmitt
Copy link
Member Author

Thanks :)

@vcunat
Copy link
Member

vcunat commented Jul 1, 2016

We originally had it enabled, I think, but after introduction of wayland-protocols the support was silently dropped. But there probably aren't many nix+wayland users, too.

@thufschmitt
Copy link
Member Author

No indeed,
But it's sad, because with a bit of packaging and some appropriate modules, it should be quite usable I think

@tg-x tg-x mentioned this pull request Oct 18, 2016
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: mass-rebuild This PR causes a large number of packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants