edit: Init at 20160425 #16707
edit: Init at 20160425 #16707
Conversation
| @@ -0,0 +1,38 @@ | |||
| { stdenv, fetchgit, unzip, pkgconfig, ncurses, x11, cwebbin }: | |||
There was a problem hiding this comment.
I wonder, is x11 supposed to be libX11?
There was a problem hiding this comment.
@joachifm updated. However, I have a question. Why does x11 work? I cant see that package in the top-level/all-packages.nix?
There was a problem hiding this comment.
It works because x11 is defined as an alias for xlibsWrapper; libX11 won't work here, actually (EDIT: it needs some additional x11 libs).
There was a problem hiding this comment.
So should I change it to xlibsWrapper or is the current (libx11 + libxft) OK? it seems to be passing in hydra
There was a problem hiding this comment.
I suppose more specific is better. In the end, you'll only end up bloating the build environment, so it's not that big of a deal (unless there are optional features you want to disable by omitting their dependencies from the environment).
Motivation for this change
Things done
(nix.useChroot on NixOS,
or option
build-use-chrootinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)