Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handbrake: depend on hicolor_icon_theme #16810

Merged
merged 1 commit into from
Jul 9, 2016
Merged

Conversation

rycee
Copy link
Member

@rycee rycee commented Jul 9, 2016

Motivation for this change

To avoid conflicts on share/icons/hicolor/icon-theme.cache.

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This avoids conflicts on `share/icons/hicolor/icon-theme.cache`.
@mention-bot
Copy link

@rycee, thanks for your PR! By analyzing the annotation information on this pull request, we identified @wmertens, @vcunat and @wizeman to be potential reviewers

@wmertens
Copy link
Contributor

wmertens commented Jul 9, 2016

This seems ok. Thanks!

@wmertens wmertens merged commit 5bf4fd7 into NixOS:master Jul 9, 2016
@rycee rycee deleted the fix/handbrake branch July 9, 2016 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants