Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w3m: fix build on darwin #16955

Merged
merged 1 commit into from
Jul 14, 2016
Merged

w3m: fix build on darwin #16955

merged 1 commit into from
Jul 14, 2016

Conversation

gilligan
Copy link
Contributor

Motivation for this change

w3m was build with graphics support enabled by default which does not compile under OSX. Setting graphicsSupport to false if stdenv.isDarwin is true makes w3m install on osx.

Things done
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [X ] Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@garbas
Copy link
Member

garbas commented Jul 14, 2016

👍 i reran the darwin travis job since it looks like we reached github api limit :)

https://travis-ci.org/NixOS/nixpkgs/jobs/144734486

@gilligan
Copy link
Contributor Author

@garbas so that is something that we will keep on running into?

@garbas garbas merged commit cb7d882 into NixOS:master Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants