prusa-slicer: use patched wxWidgets #170063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the upstream wxWidgets version prusa-slicer crashes under certain circumstances (NixOS#168358) Prusa3D provides a patched version of wxWidgets, fixing this and other issues. The 'wxGTK31-gtk3-override' option provides a way to specify the wxWidgets package, e.g. so that `super-slicer` can use its own version.
|
I guess super-slicer grown bit enough to consider splitting it off in the next bump? |
cab404
approved these changes
Apr 24, 2022
ofborg
bot
added
11.by: package-maintainer
thorstenweber83
approved these changes
Apr 26, 2022
|
LGTM. I tested the binary on x86_64 Linux. |
Artturin
added
12.approvals: 2
|
Any news on this? When it will be merged? |
1 task
|
Successfully created backport PR #176698 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
With the upstream wxWidgets version prusa-slicer crashes under certain
circumstances (#168358)
Prusa3D provides a patched version of wxWidgets, fixing this and other issues.
The 'wxGTK31-gtk3-override' option provides a way to specify the
wxWidgets package, e.g. so that
super-slicercan use its own version.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes