Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt3: fix build after multiple-outputs change #17014

Merged
merged 1 commit into from
Jul 17, 2016
Merged

Conversation

womfoo
Copy link
Member

@womfoo womfoo commented Jul 16, 2016

  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

nox-review identified 3 more dependencies (lprof, taskjuggler and twinkle) and I could make them compile successfully only when marking taskjuggler with broken = true.

Besides that, lprof and twinkle seem to work fine.

Let me know if we should mark taskjuggler as broken.

also updated source tarball path
@mention-bot
Copy link

@womfoo, thanks for your PR! By analyzing the annotation information on this pull request, we identified @edolstra, @vcunat and @bluescreen303 to be potential reviewers

@FRidh
Copy link
Member

FRidh commented Jul 16, 2016

Qt3? That's 12 years old. Is anyone still using applications that use Qt3?

@grahamc
Copy link
Member

grahamc commented Jul 16, 2016

Looks like these are the only ones in nixpkgs:

Reference: http://search.nix.gsc.io/?q=qt3


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@womfoo
Copy link
Member Author

womfoo commented Jul 17, 2016

Personally, I don't use any qt3-based apps. I just stumbled upon the build failure when poking around hydra and thought it would be interesting to fix. ;-)

I'm alright closing this PR if there isn't any demand for the apps.

ccing maintainers @markweber (lprof and twinkle) and @nbp (taskjuggler)

@vcunat vcunat merged commit 5d8005b into NixOS:master Jul 17, 2016
vcunat added a commit that referenced this pull request Jul 17, 2016
@womfoo womfoo deleted the fix/qt3 branch July 18, 2016 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants