Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tclx: init at 8.4.1 #17021

Merged
merged 1 commit into from
Jul 20, 2016
Merged

tclx: init at 8.4.1 #17021

merged 1 commit into from
Jul 20, 2016

Conversation

KoviRobi
Copy link
Contributor

@KoviRobi KoviRobi commented Jul 16, 2016

Motivation for this change

Adding Tclx, because it is required for emacspeak, but I have no idea about Tcl packages so would suggest a review by someone who knows how these work. In particular, I found I needed to set "libPrefix" to empty string, instead of "tclx${version}"

Required for #17022

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@KoviRobi KoviRobi mentioned this pull request Jul 16, 2016
7 tasks
@joachifm joachifm added the 8.has: package (new) This PR adds a new package label Jul 19, 2016
@LnL7 LnL7 merged commit 267606e into NixOS:master Jul 20, 2016
@KoviRobi KoviRobi deleted the tclx-add-at-8.4 branch October 10, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants