teamspeak_client: specify a custom, nonfree license #17028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The licensing terms depend on use [1], but the software is clearly nonfree. Previously, the package would happily build even with allowUnfree = false. [1]: http://sales.teamspeakusa.com/licensing.php
|
@joachifm, thanks for your PR! By analyzing the annotation information on this pull request, we identified @edolstra, @nathanielbaxter and @MarcWeber to be potential reviewers |
|
Good point, thanks for the patch. It looks good to me. Reminds me that the client could use a small version bump. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It is reasonable to expect that specifying
allowUnfree = falseis sufficient to ensure a system comprising only libre software. Previously,teamspeak_clientwould happily build even though it is clearly unfree per the usual definition, however.cc @Jookia raised this issue on IRC.