Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvirt: 8.1.0 -> 8.4.0 #170615

Merged
merged 3 commits into from
Jun 11, 2022
Merged

libvirt: 8.1.0 -> 8.4.0 #170615

merged 3 commits into from
Jun 11, 2022

Conversation

Kranzes
Copy link
Member

@Kranzes Kranzes commented Apr 27, 2022 •
edited
Loading

  • libvirt: 8.1.0 -> 8.4.0
  • python3Packages.libvirt: 8.1.0 -> 8.4.0
  • perlPackages.SysVirt: 8.1.0 -> 8.4.0
Things done

Tested creating a new virtual machine.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from lovesegfault, fpletz and globin April 27, 2022 12:42
@Kranzes Kranzes changed the title libvirt libvirt: 8.1.0 -> 8.2.0 Apr 27, 2022
@Kranzes Kranzes marked this pull request as ready for review April 27, 2022 13:21
@Kranzes Kranzes changed the title libvirt: 8.1.0 -> 8.2.0 libvirt: 8.1.0 -> 8.3.0 May 10, 2022
@Kranzes Kranzes force-pushed the libvirt branch 5 times, most recently from 0b7c35b to db98814 Compare May 12, 2022 13:31
@Kranzes
Copy link
Member Author

Kranzes commented May 14, 2022

Result of nixpkgs-review pr 170615 run on x86_64-linux 1

1 package marked as broken and skipped:
  • libvmi
27 packages built:
  • collectd
  • diffoscope
  • docker-machine-kvm
  • docker-machine-kvm2
  • gnome.gnome-boxes
  • haskellPackages.libvirt-hs
  • libguestfs
  • libvirt
  • libvirt-glib
  • minikube
  • minishift
  • nixops_unstable
  • perl532Packages.SysVirt
  • perl534Packages.SysVirt
  • python310Packages.guestfs
  • python310Packages.libvirt
  • python39Packages.guestfs
  • python39Packages.libvirt
  • rubyPackages.ruby-libvirt (rubyPackages_2_7.ruby-libvirt)
  • rubyPackages_3_0.ruby-libvirt
  • rubyPackages_3_1.ruby-libvirt
  • vagrant
  • virt-manager
  • virt-manager-qt
  • virt-top
  • virt-viewer
  • virtlyst

@Artturin Artturin added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 16, 2022
@Kranzes Kranzes changed the title libvirt: 8.1.0 -> 8.3.0 libvirt: 8.1.0 -> 8.4.0 Jun 10, 2022
stigtsp
stigtsp reviewed Jun 10, 2022
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM for perlPackages.SysVirt

@stigtsp
Copy link
Member

stigtsp commented Jun 10, 2022

@GrahamcOfBorg build perlPackages.SysVirt

@bobby285271 bobby285271 removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 10, 2022
@Kranzes
Copy link
Member Author

Kranzes commented Jun 10, 2022

Result of nixpkgs-review pr 170615 run on x86_64-linux 1

29 packages built:
  • appvm
  • collectd
  • diffoscope
  • docker-machine-kvm
  • docker-machine-kvm2
  • gnome.gnome-boxes
  • libguestfs
  • libguestfs-with-appliance
  • libvirt
  • libvirt-glib
  • minikube
  • minishift
  • nixops_unstable
  • ocamlPackages.ocaml_libvirt
  • perl532Packages.SysVirt
  • perl534Packages.SysVirt
  • python310Packages.guestfs
  • python310Packages.libvirt
  • python39Packages.guestfs
  • python39Packages.libvirt
  • rubyPackages.ruby-libvirt
  • rubyPackages_3_0.ruby-libvirt
  • rubyPackages_3_1.ruby-libvirt
  • vagrant
  • virt-manager
  • virt-manager-qt
  • virt-top
  • virt-viewer
  • virtlyst

@SuperSandro2000 SuperSandro2000 merged commit ae97783 into NixOS:master Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp left review comments

@fufexan fufexan fufexan approved these changes

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@zakame zakame Awaiting requested review from zakame

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kranzes @stigtsp @fufexan @SuperSandro2000 @bobby285271 @Artturin