Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rhythmbox: init at 3.2.1 #17153

Merged
merged 1 commit into from
Jul 28, 2016
Merged

rhythmbox: init at 3.2.1 #17153

merged 1 commit into from
Jul 28, 2016

Conversation

rasendubi
Copy link
Member

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Jul 21, 2016 •
edited
Loading

Looks like icons are missing. I played a wav, flac, and an mp3 successfully.

@LnL7 LnL7 added the 8.has: package (new) This PR adds a new package label Jul 22, 2016
@rasendubi
Copy link
Member Author

Fixed icons

@pSub pSub merged commit cf11470 into NixOS:master Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rasendubi @grahamc @pSub @LnL7