influxdb: parametrize default.nix to prepare packaging of 1.0 #17161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cko, thanks for your PR! By analyzing the annotation information on this pull request, we identified @zimbatm, @offlinehacker and @kamilchm to be potential reviewers |
|
With such a short build expression (where most of it is generated anyway), what is the value of parameterization? Review status: 0 of 3 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
I would like to add an additional package for for 1.0.0-beta3 and keep duplications as little as possible. |
|
Build error is fixed with f8ea8c7 . Could someone retrigger the Travis Job? |
cko
added a commit
to cko/nixpkgs
that referenced
this pull request
Jul 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Parametrize default.nix as preparation for adding a package for 1.0.0-beta3
Things done
(nix.useChroot on NixOS,
or option
build-use-chrootinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)