Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gd: 2.2.2 -> 2.2.3 #17184

Merged
merged 1 commit into from
Jul 22, 2016
Merged

gd: 2.2.2 -> 2.2.3 #17184

merged 1 commit into from
Jul 22, 2016

Conversation

mstone
Copy link
Contributor

@mstone mstone commented Jul 22, 2016

Motivation for this change

gd-2.2.3 is a security update that also includes Darwin libtool fixes for NixOS, thereby allowing us to drop a patch.

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@mstone, thanks for your PR! By analyzing the annotation information on this pull request, we identified @acowley, @vcunat and @joachifm to be potential reviewers

@joachifm
Copy link
Contributor

Builds for me.

@grahamc grahamc added the 8.has: package (update) This PR updates a package to a newer version label Jul 22, 2016
@joachifm
Copy link
Contributor

Nothing scary in the ChangeLog, either, so this should be good to go.

@joachifm joachifm merged commit d67cdde into NixOS:master Jul 22, 2016
@mstone mstone deleted the update/gd-2.2.3 branch July 22, 2016 22:04
@acowley
Copy link
Contributor

acowley commented Jul 22, 2016

Sorry I couldn't get to this more quickly, but this PR needs a follow-up to take out more of the patching machinery. Namely, the last three parameters to the expression and the extra nativeBuildInputs on darwin.

@joachifm
Copy link
Contributor

@acowley thanks for pointing that out; I've removed the left-overs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants