openmpi: Remove libibverbs on unsupported platforms #17200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libibverbs package is only available on Linux and FreeBSD, but openmpi can be used without it on platforms that don't support it.
|
@knedlsepp, thanks for your PR! By analyzing the annotation information on this pull request, we identified @bzizou, @abbradar and @aherrmann to be potential reviewers |
knedlsepp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The infiniband library
libibverbsis only supported on Linux and FreeBSD, butopenmpican be used without it on darwin or other platforms. So I remove this dependency on unsupported platforms.Things done
(nix.useChroot on NixOS,
or option
build-use-chrootinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)The libibverbs package is only available on Linux and FreeBSD, but
openmpi can be used without it on platforms that don't support it.